Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HSK labels and info #46

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add HSK labels and info #46

wants to merge 4 commits into from

Conversation

LucasRomier
Copy link

No description provided.

@ddavid
Copy link
Owner

ddavid commented Jan 22, 2020

Hi Lucas,
merge looks good at a first glance, will look into the labels tomorrow.

@LucasRomier
Copy link
Author

Sounds great!
Let me know if everything is to your liking.

@ddavid
Copy link
Owner

ddavid commented Jan 23, 2020

Unfortunately there are quite a few mislabeled cones. Blue cones labeled as being yellow and vice-versa.
I understand not labeling all the cones appearing on the image, but then there need to be clear criteria for the ones being left out as e.g. their height/width in pixels on the image. At the moment there are quite a few 'flickering' cones.
Could you please adjust the labels to be more consistent and add the criteria to your labels directory as a info.txt file?

@LucasRomier
Copy link
Author

Hi David,

After reviewing the images, we found all the problem sources.
We hope that the data is satisfactory this time.

An info.txt file has been added for clarity.

@ddavid
Copy link
Owner

ddavid commented Feb 20, 2020

Hi Lucas,

will go through it again next week on Tuesday. Currently writing my last exams this semester and will be at the ARWO this weekend.
Thanks for the update.

@ddavid
Copy link
Owner

ddavid commented Feb 27, 2020

Hi Lucas, please excuse the delay, got a bit under the weather directly after the trip back.
Will go through them later on tonight.

@ddavid
Copy link
Owner

ddavid commented Feb 28, 2020

Hi Lucas,
unfortunately there are still too many cones that weren't labeled, starting by the orange and big orange cones. I'll send you more detailed feedback tomorrow, probably together with some examples.

@ddavid
Copy link
Owner

ddavid commented Feb 29, 2020

Hi Lucas, here are two examples of partially cut cones that should be labeled.

Yellow cone on the right hand side of the image.
boxes_00003767_skid-pad

Blue cone on the left hand lower corner of the image.
boxes_00003631_skid-pad

As a rule of thumb, label every cone which is more than 50% visible .
Not labeling cones occluded by other cones as per your info.txt is completely valid, despite that rule of thumb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants