Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DJSR labels added #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DJSR labels added #68

wants to merge 2 commits into from

Conversation

smrutib
Copy link

@smrutib smrutib commented Mar 24, 2020

Added DJS Racing's labels and documentation

@ddavid
Copy link
Owner

ddavid commented Mar 26, 2020

Hi Smruti, I will probably go through the PR tomorrow in the evening. I will keep you posted.

@smrutib
Copy link
Author

smrutib commented Mar 27, 2020 via email

@ddavid
Copy link
Owner

ddavid commented Mar 27, 2020

Hi there,
so unfortunately there are a few issues so far.
I've only gone through the first ~300 images because at image pwd117-cockpit00001038.jpg there's a wrong class index. Your classes file has three classes, so please check that all the indices are in the range from [0-2].
There are also a few misclassified cones, here are two examples:
boxes_pwd117-cockpit00000777

boxes_pwd117-cockpit00000816

Furthermore, I appreciate the info.txt on what cones were left out, but please be more specific.

@smrutib
Copy link
Author

smrutib commented Apr 4, 2020 via email

@ddavid
Copy link
Owner

ddavid commented Apr 7, 2020

Hi Smruti,
thank you for the summary of the changes made. I will let you know as soon as I have feedback on the current version of the labels.

@ddavid
Copy link
Owner

ddavid commented Apr 9, 2020

Hi Smruti,

the issues from the first comment are fixed, thank you.

I'm afraid I wasn't specific enough with my feedback on the info.txt file, though. The purpose behind it is for other teams to be able to pre-process the files to better fit their algorithms.
What a very small cone is might vary from team to team, your file should be clear as to what that means for yours. As a rule of thumb, if you can't put the information in quantifiable terms somehow, it won't be of much use for the other teams.
An example of this would be the size of the bounding boxes in Pixels, e.g. labeling all cones with a height > 10 Pixels.
Another example would be to set a height on the image plane up to which you've labeled. This cutoff line would only make sense if all images were taken with the camera in the same pose, more or less, making the assumption of a fixed horizon possible.

Regarding the quality of the labels, I will send you a sample with good examples, the bounding boxes should be tighter around the cones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants