Conversation
Addition of the proper documentation
ml_peg/calcs/surfaces/metal_surface_reconstructions/calc_metal_surface_reconstructions.py
Outdated
Show resolved
Hide resolved
|
Hi, ive uploaded the data and made a code suggestion for the s3 bucket download with the path i've uploaded it to + tested it |
…_surface_reconstructions.py Co-authored-by: Joseph Hart <[email protected]>
|
Thanks I accepted you suggestions. I also cleaned the old files up now. So it should be completely done now. Thanks again |
ml_peg/analysis/surfaces/metal_surface_reconstructions/analyse_metal_surface_reconstructions.py
Outdated
Show resolved
Hide resolved
ml_peg/analysis/surfaces/metal_surface_reconstructions/analyse_metal_surface_reconstructions.py
Outdated
Show resolved
Hide resolved
…_metal_surface_reconstructions.py Co-authored-by: Joseph Hart <[email protected]>
…_metal_surface_reconstructions.py Co-authored-by: Joseph Hart <[email protected]>
|
Hi @joehart2001, it seems that the test/suit broke, I don't really understand the error/part where it breaks. Is there anything I can do to fix that? |
@ElliottKasoar any ideas? |
Hi @Felixrccs, the error isn't from the 'tests', but from the pre-commit, which applies various automated linting/docstring checks to ensure consistency of code. See here for a bit more detail. If you install this locally and run something along the lines of |
|
Damn the pre-commit is neat. I adapted everything and went over the Docstings as well, now it should pass the test. Thx for the help |
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
Geometry optimizations of Cu(111)O and Pd/Au(111)C/O/N surface reconstructions and evaluation of surface energy and structural integrity.
Progress
Testing
Most mace models
New decorators/callbacks
No