-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NO_COLOR, inject version tag, and more #124
base: master
Are you sure you want to change the base?
Conversation
There are plenty of environments without BASH, but with sh.
These could have caused problems: $!"\
- exit if directory doesn't exist - source .profile only if it exists - don't suppress stderr while doing that
Injects Makefile arg VERSION into main.Version with default value of "dev".
The output padding is based upon the longest name of processes and thus never changes at runtime so we can optimize things a bit by only creating the output formatter pattern once at startup.
Hi there 👋 There seems to be quite a lot of requests for supporting a "no color" output (including from me 😄), I think merging this in would be a "quick win". @ddollar Could this be reviewed? Apologies, if you're not maintaining this repo anymore, but if that is the case could you point me to who is maintaining the repo? Thank you. |
@sehrope, nice work. I've closed my pull request, hopefully someone will merge this in soon. Regards, |
As there hasn't been any activity in this repo in a while, I'm publishing the changes in my fork at: https://github.com/sehrope/forego It includes everything from this PR as well as some updates to the go version, changes to use go modules, GitHub Actions for CI, and has pre-built binaries as GitHub releases for Linux, OSX, and Windows (https://github.com/sehrope/forego/releases). If things every open up again here we can merge back. |
This PR is a rebased version of #122 with a couple more commits added by me. That original PR improves the error handling and adds automatic disabling of color output based on whether stdout is a terminal.
This PR expands on that with a few more commits to:
$ make VERSION="$(date --utc +%Y%m%d-%H%M%S)-$(git show-ref -s -- HEAD)" build ... $ forego version 20200605-120321-0bdbf9b27cf9da13e246ff1ba90ab5961f4be849