Change default argument for ByGroup

ddotta · May 27, 2024 · e3624ef · e3624ef
1 parent 293082a
commit e3624ef
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/R/add_table.R b/R/add_table.R
@@ -34,7 +34,7 @@ add_table <- function(
     TableFootnote2 = "",
     TableFootnote3 = "",
     MergeCol = NULL,
-    ByGroup = NULL,
+    ByGroup = character(0),
     GroupName = FALSE,
     asTable = FALSE) {
 
@@ -51,7 +51,7 @@ add_table <- function(
   assert_character1(TableFootnote2)
   assert_character1(TableFootnote3)
 
-  if (asTable & !is.null(ByGroup)) {
+  if (asTable & length(ByGroup) > 0L) {
     stop("asTable cannot be TRUE if ByGroup is defined")
   }
 
@@ -98,7 +98,7 @@ add_table <- function(
   }
 
   # Add a table
-  if (is.null(ByGroup)) {
+  if (length(ByGroup) == 0L) {
     writeDataFunction(
       wb = WbTitle,
       sheet = mysheet,

diff --git a/R/toxlsx.R b/R/toxlsx.R
@@ -47,7 +47,7 @@ toxlsx <- function(object,
                    footnote2 = list(),
                    footnote3 = list(),
                    mergecol = NULL,
-                   bygroup = NULL,
+                   bygroup = list(),
                    groupname = FALSE,
                    path,
                    filename = "Export",