-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(csp): update ol and fix webpack global emit (#2138) #6009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dagda1, this breaks our demo site and our e2e tests.
See error from the deploy preview:
6b12e9e
to
859e083
Compare
Added a comment, also not sure what's up with this check https://github.com/netlify/netlify-cms/pull/6009/checks?check_run_id=4446496928 as we don't use Azure pipelines |
I think it is because there was a merge conflict which is now fixed. Everything is.........green (at this time of writing). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 This is good to go
Summary
We are using netlify-cms for a client who has a strict csp policy that would forbid adding:
to the csp.
After looking into the problem, it would appear that rbush which is here in the dependency tree:
Is using
new Function("blah"
calls which will get blocked by csp unless theunsafe-
directives are added.Upgrading
ol
to6.9.0
upgradesrbush
to3.0.1
where thenew Function
calls have been replaced: