feat: remove deleted image from content #7310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added configuration option for removing deleted image from content. Instead of saving empty string.
closes #7120
closes #7186
I wasn't sure that this should be working by default, that's why I extended cms configuration with new option
remove_empty_image_field. conected PR for docs will follow.Implementation is overlapping with logic for #3314 , which inserts default values for all removed entries. The same reason prevented me from saving image value as
nullorundefinedinstead of empty string.Test plan
BEFORE:
AFTER:
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)
