fix: slugFormatter populates date template variables using date from entry if it exists #7633
+34
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to issue #6801 , though takes a different approach than that requested in the issue description. this PR tentatively implements solution 1 outlined in this issue comment, though could pivot to another solution if preferred!
Summary
currently, when configuring the slug, the template tags
{{year}}
,{{month}}
, etc are always pulled from the hardcoded "now".in this PR, if the entry contains an inferred
'date'
field, we use that value when generating the slug.thus, the following slug config would pull the template tags
{{year}}
,{{month}}
, etc from the entry's front matter inferred'date'
field if it exists (or otherwise, "now"):notes for evaluating slugFormatter's expected behavior w.r.t. date template tags:
slugFormatter
's behavior consistent with that offolderFormatter
, which already uses the date from the entry's front matter by default.slugFormatter
's behavior with this piece of documented behavior:slugFormatter
's behavior more nuanced than this piece of documented behavior impliesTest plan
{{year}}
,{{month}}
, etc are pulled from the entry's front matter "date" field if it existsChecklist
Please add a
x
inside each checkbox:A picture of a cute animal (not mandatory but encouraged)
