Open
Conversation
Contributor
I think it might be related to GitHub itself, there's some ungoing issues with Actions, I'll see if there's any issues happening locally 
|
yanthomasdev
reviewed
Mar 5, 2026
Comment on lines
+39
to
+40
| console.log(`Starting teardown for: ${spec} - ${testName}`); | ||
| const startTime = Date.now(); |
Contributor
There was a problem hiding this comment.
This might not be super consistent, that will be executed with the function, but not exactly the moment Cypress starts teardown because of its queue system.
Maybe something like this workarounds this matter? But again, not really something that would make a big difference, I believe.
Suggested change
| console.log(`Starting teardown for: ${spec} - ${testName}`); | |
| const startTime = Date.now(); | |
| let startTime; | |
| cy.then(() => { | |
| startTime = Date.now(); | |
| console.log(`Starting teardown for: ${spec} - ${testName}`); | |
| }); |
yanthomasdev
approved these changes
Mar 5, 2026
Contributor
yanthomasdev
left a comment
yanthomasdev
left a comment
There was a problem hiding this comment.
Looks good to me, I have a small nit but not blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are hanging for no apparent reason. This PR will solve it hopefully. For now I added some logging to identify the problem.
Also reduces timeout from 1hr to 30 min.