-
Notifications
You must be signed in to change notification settings - Fork 36
Fix voting cards authorization loading and index page display #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
==========================================
- Coverage 96.66% 93.75% -2.91%
==========================================
Files 157 158 +1
Lines 4082 4086 +4
==========================================
- Hits 3946 3831 -115
- Misses 136 255 +119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…new styles, add spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is improving!
- see that some views still look not good, specially in the grid for some same-small screens
One solution we could apply is to remove the flex-direction: column from the .vote-block, the it looks much nicer:


- The "loading" status does not appear in the list
- Also, the instructions box does not appear
| end %> | ||
| <% end %> | ||
| </div> | ||
| <% end %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldn't be this part the vote_block_for ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've applied som css corrections.
I've found that in the list view, no title in the modal is shown.

Other things to consider:
- The Readme file mentions the metadata cell, needs to be updated
- In this PR, the modal in the list is created as many times as the items in the list. Can we just add one modal and update the content?
- The VotingCardsProposalCell is too complicated, can we create two cells that inheritht one from the other? let's render one or the other depending on if it is comming from a list or not.
- There is a problem when you vote on the list, it renders the cell inside the class
voting-voting_cardswhen updates the cell, leading to css mistmaches:
I think this happens because the file _show_vote_button.html.erb
`
| if (proceedButton) { | ||
| proceedButton.addEventListener("click", () => { | ||
| if (modal.storedAction) { | ||
| modal.storedAction.click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we find the voting container here and add the "loading" class too?
| Decidim::Proposals::ProposalVote.include(Decidim::DecidimAwesome::HasVoteWeight) | ||
| Decidim::Proposals::ProposalType.include(Decidim::DecidimAwesome::AddProposalTypeVoteWeights) | ||
| Decidim::Proposals::ProposalLCell.include(Decidim::DecidimAwesome::ProposalLCellOverride) | ||
| Decidim::Proposals::ProposalGCell.include(Decidim::DecidimAwesome::ProposalGCellOverride) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add this to the checksum.yml


Fixes #478