Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter offenses fixes to action backporter #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andreslucena
Copy link
Member

As there are some differences between the rubocop configuration between versions, there are some linter offences that happens in some versions and not in others.

See decidim/decidim#13444

This PR adds the automation for adding these linter fixes automated in the workflow

Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks ok, i have tested the code.

@alecslupu
Copy link
Contributor

@andreslucena you have failing specs

@andreslucena
Copy link
Member Author

I realized that I need to actually do the backports in the decidim-backporter script, as that's the one that actually generates the cherry-pick/PR. I'll do it when I have some availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants