Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activesupport dependency requirement #5

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

andreslucena
Copy link
Member

While working with the gem, I realized that I made a mistake with the activesupport requirement, as I've added it as a development requirement but it's actually also for production usage:

$ grep -r active_support lib/
lib/decidim/maintainers_toolbox/github_manager/poster.rb:require "active_support/core_ext/hash/except"
lib/decidim/maintainers_toolbox/github_manager/querier/by_label.rb:require "active_support/core_ext/time/zones"
lib/decidim/maintainers_toolbox/backports_reporter/cli_report.rb:require "active_support/core_ext/string/filters"

This PR fixes this error. We should do a release after merging this (v0.2.0)

Testing

To check the bug:

Start with a new version of ruby without any gem installed (only the default ones)
Install decidim-maintainers_toolbox gem: gem install decidim-maintainers_toolbox
Try to use the gem
See error

Stacktrace

$ decidim-backports-checker --github-token=(gh auth token) --last-version-number 0.28 --days-to-check-from 10
Traceback (most recent call last):
        8: from /home/apereira/.local/share/mise/installs/ruby/2.7.6/bin/decidim-backports-checker:23:in `<main>'
        7: from /home/apereira/.local/share/mise/installs/ruby/2.7.6/bin/decidim-backports-checker:23:in `load'
        6: from /home/apereira/.local/share/mise/installs/ruby/2.7.6/lib/ruby/gems/2.7.0/gems/decidim-maintainers_toolbox-0.1.0/exe/decidim-backports-checker:6:in `<top (required)>'
        5: from /home/apereira/.local/share/mise/installs/ruby/2.7.6/lib/ruby/gems/2.7.0/gems/decidim-maintainers_toolbox-0.1.0/exe/decidim-backports-checker:6:in `require_relative'
        4: from /home/apereira/.local/share/mise/installs/ruby/2.7.6/lib/ruby/gems/2.7.0/gems/decidim-maintainers_toolbox-0.1.0/lib/decidim/maintainers_toolbox/git_backport_checker.rb:5:in `<top (required)>'
        3: from /home/apereira/.local/share/mise/installs/ruby/2.7.6/lib/ruby/gems/2.7.0/gems/decidim-maintainers_toolbox-0.1.0/lib/decidim/maintainers_toolbox/git_backport_checker.rb:5:in `require_relative'
        2: from /home/apereira/.local/share/mise/installs/ruby/2.7.6/lib/ruby/gems/2.7.0/gems/decidim-maintainers_toolbox-0.1.0/lib/decidim/maintainers_toolbox/github_manager/querier/by_label.rb:3:in `<top (required)>'
        1: from /home/apereira/.local/share/mise/installs/ruby/2.7.6/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
/home/apereira/.local/share/mise/installs/ruby/2.7.6/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require': cannot load such file -- active_support/core_ext/time/zones (LoadError)

Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu merged commit 5d0b7d9 into main Mar 24, 2024
1 check passed
@alecslupu alecslupu deleted the fix/activesupport-dependency branch March 24, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants