Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spellchecker #160

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

Add spellchecker #160

wants to merge 17 commits into from

Conversation

alecslupu
Copy link
Contributor

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

.github/actions/spelling/expect.txt Fixed Show fixed Hide fixed
.github/actions/spelling/expect.txt Fixed Show fixed Hide fixed
.github/actions/spelling/expect.txt Fixed Show fixed Hide fixed
.github/actions/spelling/expect.txt Fixed Show fixed Hide fixed
.github/actions/spelling/expect.txt Fixed Show fixed Hide fixed
.github/actions/spelling/expect.txt Fixed Show fixed Hide fixed
.github/actions/spelling/expect.txt Fixed Show fixed Hide fixed
.github/actions/spelling/expect.txt Fixed Show fixed Hide fixed
.github/actions/spelling/expect.txt Fixed Show fixed Hide fixed
.github/actions/spelling/expect.txt Fixed Show fixed Hide fixed
@alecslupu alecslupu marked this pull request as ready for review October 4, 2024 11:44
@alecslupu alecslupu requested a review from andreslucena October 4, 2024 11:44
@RCheesley
Copy link
Contributor

Hi there! We implemented Vale a while back, which also does spell checking. Is there a need to have another solution?

@alecslupu
Copy link
Contributor Author

alecslupu commented Oct 4, 2024

Hi there! We implemented Vale a while back, which also does spell checking. Is there a need to have another solution?

It has to do with: #159
Maybe Vale is just missing some configuration?

Apparently Vale did not caught the error, and is not catching either some others...

And i could add a few more examples.

@alecslupu
Copy link
Contributor Author

Hi there! We implemented Vale a while back, which also does spell checking. Is there a need to have another solution?

As a fun note, reading https://github.com/decidim/documentation/blob/44e3b5bd92a5e05140fa378df5f0a87966139b49/.github/actions/spelling/expect.txt

i found a few more:

  • matchs
  • mehod
  • mesage
  • propsoals
  • particpant
  • possiblity
  • plaform
  • underlied
  • verfication

@RCheesley
Copy link
Contributor

Hey hey! Here's a PR which fixes the Vale linter. It was silently failing (how incredibly unhelpful!)

@alecslupu
Copy link
Contributor Author

alecslupu commented Oct 25, 2024

Hey hey! Here's a PR which fixes the Vale linter. It was silently failing (how incredibly unhelpful!)

Yes, but now we still have typos in the documentation that needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants