Skip to content

Install capistrano gems #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025
Merged

Install capistrano gems #144

merged 3 commits into from
Apr 30, 2025

Conversation

fblupi
Copy link
Member

@fblupi fblupi commented Apr 28, 2025

No description provided.

@fblupi fblupi requested a review from andreslucena April 29, 2025 07:41
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As they are only the gems, LGTM.

What about the config itself (Capfile, config/deploy.rb, config/deploy/production.rb)?

@fblupi
Copy link
Member Author

fblupi commented Apr 29, 2025

As they are only the gems, LGTM.

What about the config itself (Capfile, config/deploy.rb, config/deploy/production.rb)?

As they contain sensible information, we have it in a private repository. I think we should move it to a repository inside the decidim organization, but, as we were in a hurry with the migration stuff, we have it in a private repository from the Platoniq organization.

@andreslucena
Copy link
Member

andreslucena commented Apr 29, 2025

Capfile and config/deploy.rb shouldn't have any private information
config/deploy/production.rb can have something private (like ports and bastion IPs and things like that). On those cases I put that information in .ssh/config or just use env vars (and documented them in a private wiki for instance, or Bitwarden)

@fblupi
Copy link
Member Author

fblupi commented Apr 29, 2025

Ok, I can commit them with env variables. Let me do it before merging this one

@fblupi fblupi requested a review from andreslucena April 29, 2025 08:20
@andreslucena andreslucena merged commit 7ac960b into master Apr 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants