Feat: Add browserless App #1087
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging OptionsShould a new tag be published when this PR is merged?
|
matheusgr
suggested changes
Apr 8, 2025
| @@ -0,0 +1,973 @@ | |||
| const BASE_URL = "https://chrome.browserless.io"; | |||
There was a problem hiding this comment.
this is the BaaS V1. Shouldn't we be using BaaS V2?
| /** | ||
| * @description Represents the response structure from the Browserless API. | ||
| */ | ||
| interface BrowserlessApiResponse<T = unknown> { |
There was a problem hiding this comment.
Create a type.ts only for types, so the client can focus on the logic itself.
Comment on lines
+631
to
+638
| let errorMessage = | ||
| `Browserless API failed: ${response.status} ${response.statusText}`; | ||
| try { | ||
| const errorData = await response.json(); | ||
| errorMessage += `. Details: ${JSON.stringify(errorData)}`; | ||
| } catch (_) { | ||
| // Ignore JSON parsing error | ||
| } |
There was a problem hiding this comment.
extract to function and reuse.
| /** | ||
| * @description Download files using the browser | ||
| */ | ||
| async download(params: DownloadParams): Promise<{ base64Image: string }> { |
There was a problem hiding this comment.
it seems that all functions have the same "body":
given an URL, extract token, fetch, test for error, process response.
Maybe you should create a base function that receives the URL, and a lambda to process response, and wrap all the functions from this client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this Contribution About?
Feat: Add browserless App
Please provide a brief description of the changes or enhancements you are proposing in this pull request.
Issue Link
Please link to the relevant issue that this pull request addresses:
Loom Video
Demonstration Link