multi: Misc error simplification and cleanup. #3491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does some basic error-related housekeeping to simplify all print-related formatting as follows: - Use the error directly as opposed to unnecessarily manually invoking the Error method - Avoid unneeded formatting directives when the output only consists of the error itself - Use const strings when matching on fixed error strings - Wrap errors when using fmt.Errorf
davecgh
force-pushed
the
multi_misc_error_cleanup
branch
from
38fd3f6 to
04c4e2d
Compare
jrick
approved these changes
Jun 12, 2025
| @@ -1163,8 +1163,7 @@ func TestGetSStxNullOutputAmounts(t *testing.T) { | |||
| amtTicket) | |||
|
|
|||
| // len commit to amts != len change amts | |||
| lenErrStr := "amounts was not equal in length " + | |||
| "to change amounts!" | |||
| const lenErrStr = "amounts was not equal in length to change amounts!" | |||
There was a problem hiding this comment.
wow these error messages are gross.
besides that, it would be nice to have some defined error variables to test this against (they don't need to be exported).
There was a problem hiding this comment.
Agreed. I noticed they really need to be cleaned up and converted to errors.Is and all like the rest of the code too, but was limiting the scope of this PR. Plus, a lot of this module will eventually be rewritten/cleaned in favor of the primitives module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does some basic error-related housekeeping to simplify all print-related formatting as follows:
Errormethodfmt.Errorf