Replace embedded Groups with type assertions#550
Merged
AnomalRoil merged 2 commits intodedis:masterfrom Sep 23, 2024
Merged
Conversation
These were always nil and likely unintentional (I assume it started out as a way to mock unimplemented interface methods?). It doesn't matter much because these suites all implement `kyber.Group`, but any changes to `kyber.Group` would have added panicing methods to these suites without any type errors.
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
AnomalRoil
approved these changes
Sep 23, 2024
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were always nil and likely unintentional (I assume it started out as a way to mock unimplemented interface methods?). It doesn't matter much because these suites all implement
kyber.Group, but any changes tokyber.Groupwould have added panicing methods to these suites without any type errors.