Fixed count limit for response paging in two situations #1118
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when using a count that is higher than the maximum features that can be retrieved, the request URIs generated for the next requests would have gaps, as the start index would still be increased by the given count and the count would be retained as well.
Limit the count for the previous paged response in case the difference to the current start index is less than the original count.
tfr42
changed the title
tfr42
added
contributions welcome
Member
|
Thank you for your contribution. Unfortunately, it cannot be merged automatically. It cannot be considered for inclusion, before this has been fixed. Please rebase it against the target |
|
Thank you for your contribution. Unfortunately, this PR has been inactive for 90 days (see PR stuck workflow). Of course this is not the final word. The PR can become unstuck, for example, by reengaging in the discussion, answering open questions, rebasing, or adding new commits to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix behavior when count provided for response paging is higher than the maximum features limit that is configured.
Previously when using a count that is higher than the maximum features that can be retrieved, the request URIs generated for the next requests would have gaps, as the start index would still be increased by the given count and the count would be retained as well.
Limit the count for the previous paged response in case the difference to the current start index is less than the original count.