-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shifting to tag-based functionality for registration questions & attendance/check-in #1157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Always a pleasure to read your code! :))
Will wait until you've added the tests to approve.
Completed some more systematic testing and all looks good. Adding the scenarios I tested here for our records: --invited guest, not registered, not paid, not signed online indemnity form -- PASSED; payment not required for invited guests --invited guest with offer, not registered, not paid, not signed online indemnity form -- PASSED, payment not required for invited guests |
Noting that we only check the 'confirmed' field in a user's registration entry to determine if they have paid or not. If they have not registered and not paid, then they can still be checked in. We've left this as-is for Indaba 2023, as all attendees have registered, but I have logged a bug here for future events. |
Included in this PR:
registration_metadata
andoffer_metadata
fields which are lists of dicts containing relevant info.registration_metadaset
contains name/response pairs for all the registration questions which had tags and the user's corresponding answers.offer_metadata
just extracts the names of the tags attaches to the user's offer.registration_metadata
, and displays it. Currently, theoffer_metadata
is not shown though can easily be added.I have tested this very briefly. Will continue testing over the next days.