Issue/71 async transcribe prerecorded result#111
Merged
lukeocodes merged 14 commits intodeepgram:mainfrom Aug 11, 2023
Merged
Conversation
…allback for completion.
Marking all async tests as Tasks instead of voids.
…TranscriptionClient.
…lback url over and over.
… as long as callbackUrl is sent as null/empty in async call.
…cription is requested.
ThindalTV
changed the title
ThindalTV
changed the title
Collaborator
Author
|
Fixes #71 |
…th no callbackUrl argument but with Callback set in the options object. Now works as previously.
Collaborator
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for returning the request_id from requests to asynchronously transcribe prerecorded audio.
Adds tests of the same.
Minor cleanup.
Breaking change: Old method cannot be called if async transcription is requested. The new method overload must be used instead.For this reason, PrerecordedTranscriptionOptions.Callback is now marked as obsolete.Heavily influenced by #61 but doesn't break compilation of current implementations and returns a custom object only containing pertinent information when async transcribe is requested.
Also fixes unrelated test so that all tests pass now.