Issues/116 crash on multiple set time out calls #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the Deepgram base client.
…d pass an instance around as required.
|
is this a breaking change for users? |
none of the changes users will see |
lukeocodes
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116.
Fixes the issue where a static and shared HttpClient was passed around all instances of DeepgramClient, no matter if it was still in memory or not(as the HttpClient was still around anyways). This resulted in any calls to SetTimeout after the first request had been sent from ANY DeepgramClient to fail with an exception.
This also sets up recreation of the HttpClient used inside of the DeepgramClient instance when the timeout changes, so that it can be reset to something else, on a per client basis.
Basically, this makes each DeepgramClient instance independent from each other, and makes it possible to modify the timeout even after the client has been used to send & recieve the first requests.