-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Finalize
and AutoFlush Functionality
#311
Conversation
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 86 files out of 158 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@coderabbitai review |
Actions performedReview triggered.
|
e74a1e5
to
26c54e0
Compare
26c54e0
to
c6ed607
Compare
Addresses: #296, #276, #250
This implements fixes for:
no_delay
Add Support forno_delay
#276Finalize
and AutoFlush Implement Flush Feature #250This also restructures the
PreRecorded
andLiveClient
to place them under theDeepgram.Clients.Listen
and for their Model objects, theDeepgram.Models.Listen
. This preserves the backward compatibility of the older objects/constants/etc., with a warning to update them as they will be removed in a future version. This makes it so all projects referencing old objects will still build and run, allowing users to migrate at their convenience before the next major version.Deepgram.Clients
ChangesSince TTS WS was implemented this way, the STT Clients have been reorganized similarly. To demonstrate the approach for
clients
on this PR, the following changes were made to the clients.The way it was before:
The files were moved into a
pkg/client/<type>/v1
folder, and thepkg/client/<type>
created backward-compatible links to artifacts in these newv1
folders.Deepgram.Models
ChangesSince TTS WS is implemented this way, the STT Models are reorganized similarly. The implementation of TTS WS was done purposely so that this change could be made easily. These changes then follow the client in a similar fashion.
The way it was before:
The files were moved into a
pkg/api/<type>v1
folder and thepkg/client/<type>
created backward-compatible links to artifacts in these newv1
folders.The users' code should remain unchanged, but now hint that there are deprecated packages in use to be removed at the next major release. This is what it will look like in the IDE/editor by way of a strikethrough (picture below) and this warning in the deprecated packages:
The README was NOT updated because they need to be updated for
Listen
andSpeak
. Will do so in a subsequent PR.