-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WebSocket Listen Reconnect Example #338
Update WebSocket Listen Reconnect Example #338
Conversation
Warning Rate limit exceeded@dvonthenen has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 0 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe pull request introduces several modifications to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (4)
- Deepgram.Dev.sln (3 hunks)
- examples/speech-to-text/websocket/microphone/Program.cs (1 hunks)
- tests/edge_cases/reconnect_same_object/Program.cs (2 hunks)
- tests/edge_cases/reconnect_same_object/ReconnectStreaming.csproj (1 hunks)
🔇 Additional comments (5)
tests/edge_cases/reconnect_same_object/ReconnectStreaming.csproj (1)
11-11
: LGTM! Verify project structure for the new reference.The addition of the
Deepgram.Microphone.csproj
reference aligns with the PR objectives and is likely necessary for the WebSocket Listen Reconnect Example functionality.Please run the following script to verify the project structure and ensure the referenced project exists:
✅ Verification successful
Project reference verified successfully.
The
Deepgram.Microphone.csproj
file exists in the specified location.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the Deepgram.Microphone.csproj file # Test: Check if the Deepgram.Microphone.csproj file exists # Expect: The file should exist in the specified location fd -p "Deepgram.Microphone/Deepgram.Microphone.csproj" --max-depth 4Length of output: 115
Deepgram.Dev.sln (4)
168-171
: New project addition looks good.The new "ReconnectStreaming" project has been properly added to the solution under the "reconnect_same_object" folder. This structure is consistent with other test projects in the solution.
310-313
: Project configuration is correct.The configuration for the new "ReconnectStreaming" project has been properly set up with both Debug and Release configurations. This is consistent with other projects in the solution.
393-394
: Nested project structure is appropriate.The new "ReconnectStreaming" project is correctly nested under the "reconnect_same_object" folder within the "edge_cases" category. This structure is logical and consistent with the organization of other test projects in the solution.
168-171
: Overall, the changes to the solution file are well-structured and consistent.The addition of the new "ReconnectStreaming" project, its configuration, and its placement within the solution structure have been implemented correctly. These changes align with the existing patterns in the solution file and follow best practices for organizing test projects.
Also applies to: 310-313, 393-394
dff557d
to
51927c0
Compare
51927c0
to
6811cd2
Compare
Proposed changes
This updates the Listen WS example to add more color to what is going on. It was also missing from the Developer Solution file for some reason.
Types of changes
What types of changes does your code introduce to the community .NET SDK?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
NA
Summary by CodeRabbit
New Features
reconnect_same_object
.ReconnectStreaming
.Improvements
Bug Fixes