fix(CI): pin protobuf<7.34#5272
Conversation
See tensorflow/tensorflow@23f7b26 Signed-off-by: Jinzhe Zeng <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s CI/dev dependency groups to avoid TensorFlow breakage caused by newer protobuf releases, by adding an explicit protobuf upper bound alongside tighter TensorFlow pins.
Changes:
- Hard-pin
tensorflow-cputo2.20.0on Linux x86_64 inpin_tensorflow_cpu. - Hard-pin
tensorflowto2.18.0inpin_tensorflow_gpu. - Add
protobuf<7.34.0to both TensorFlow pin groups to prevent incompatibleprotobufupgrades.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📝 WalkthroughWalkthroughThis PR updates TensorFlow version pins and adds protobuf constraints in pyproject.toml. The CPU Linux pin is locked to version 2.20.0, the GPU pin is tightened from ~= to ==2.18.0, and protobuf<7.34.0 is added to both pin groups. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pyproject.toml`:
- Around line 156-161: The protobuf constraint "protobuf<7.34.0" in
pyproject.toml is too permissive for TensorFlow 2.20.0; update the dependency
line that currently reads "protobuf<7.34.0" to match TensorFlow's requirement by
using a stricter constraint such as "protobuf>=5.28.0,<7.0" (or at minimum
"protobuf<7.0") so it aligns with the tensorflow==2.20.0 entry and prevents
installing unsupported 7.x protobuf releases.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5272 +/- ##
=======================================
Coverage 82.00% 82.00%
=======================================
Files 750 750
Lines 75215 75215
Branches 3615 3615
=======================================
Hits 61680 61680
Misses 12372 12372
Partials 1163 1163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
See tensorflow/tensorflow@23f7b26
Summary by CodeRabbit