Skip to content

fix(CI): pin protobuf<7.34#5272

Merged
wanghan-iapcm merged 1 commit intodeepmodeling:masterfrom
njzjz:pin-protobuf
Feb 27, 2026
Merged

fix(CI): pin protobuf<7.34#5272
wanghan-iapcm merged 1 commit intodeepmodeling:masterfrom
njzjz:pin-protobuf

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Feb 27, 2026

See tensorflow/tensorflow@23f7b26

Summary by CodeRabbit

  • Chores
    • Updated TensorFlow versions and added protobuf constraints for improved stability across CPU and GPU configurations.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s CI/dev dependency groups to avoid TensorFlow breakage caused by newer protobuf releases, by adding an explicit protobuf upper bound alongside tighter TensorFlow pins.

Changes:

  • Hard-pin tensorflow-cpu to 2.20.0 on Linux x86_64 in pin_tensorflow_cpu.
  • Hard-pin tensorflow to 2.18.0 in pin_tensorflow_gpu.
  • Add protobuf<7.34.0 to both TensorFlow pin groups to prevent incompatible protobuf upgrades.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

📝 Walkthrough

Walkthrough

This PR updates TensorFlow version pins and adds protobuf constraints in pyproject.toml. The CPU Linux pin is locked to version 2.20.0, the GPU pin is tightened from ~= to ==2.18.0, and protobuf<7.34.0 is added to both pin groups.

Changes

Cohort / File(s) Summary
Dependency Version Pinning
pyproject.toml
Updated TensorFlow CPU Linux pin to ==2.20.0 (from >=2.18,<2.21), tightened GPU pin to ==2.18.0 (from ~=2.18.0), and added protobuf<7.34.0 constraint to both pin_tensorflow_cpu and pin_tensorflow_gpu dependency groups.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • wanghan-iapcm
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: adding a protobuf version constraint to fix CI issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pyproject.toml`:
- Around line 156-161: The protobuf constraint "protobuf<7.34.0" in
pyproject.toml is too permissive for TensorFlow 2.20.0; update the dependency
line that currently reads "protobuf<7.34.0" to match TensorFlow's requirement by
using a stricter constraint such as "protobuf>=5.28.0,<7.0" (or at minimum
"protobuf<7.0") so it aligns with the tensorflow==2.20.0 entry and prevents
installing unsupported 7.x protobuf releases.

ℹ️ Review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f959a53 and f75cd0d.

📒 Files selected for processing (1)
  • pyproject.toml

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.00%. Comparing base (f959a53) to head (f75cd0d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5272   +/-   ##
=======================================
  Coverage   82.00%   82.00%           
=======================================
  Files         750      750           
  Lines       75215    75215           
  Branches     3615     3615           
=======================================
  Hits        61680    61680           
  Misses      12372    12372           
  Partials     1163     1163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Feb 27, 2026
Merged via the queue into deepmodeling:master with commit 21d2b1a Feb 27, 2026
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants