Skip to content

fix: empty dataframe after filtering #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
Merged

fix: empty dataframe after filtering #253

merged 2 commits into from
Jun 23, 2025

Conversation

sg-s
Copy link
Collaborator

@sg-s sg-s commented Jun 23, 2025

No description provided.

@sg-s sg-s requested a review from a team as a code owner June 23, 2025 13:32
@sg-s sg-s requested a review from Copilot June 23, 2025 13:32
@sg-s sg-s self-assigned this Jun 23, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR ensures that the DataFrame is returned early if it becomes empty after any filtering step, preventing downstream operations on an empty set.

  • Added if len(df) == 0: return df after pocket_center and box_size filters
  • Updated metadata and user_inputs filters to only run when len(df) > 0
  • Kept existing filter logic but short-circuited on empty DataFrames

@checkmarx-do
Copy link

checkmarx-do commented Jun 23, 2025

Logo
Checkmarx One – Scan Summary & Details2b62dfc9-6a1f-4c39-8ca0-7c00842523f9

New Issues (8)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
HIGH Passwords And Secrets - Generic Token /pypi.yml: 16
detailsQuery to find passwords and secrets in infrastructure code.
ID: PnAY6CxnFy1YkFnuYmjaU12eG2Q%3D
LOW Unpinned Actions Full Length Commit SHA /test_ufa.yaml: 30
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: MQKOgi2Mc4YFrlSXC8h5OBQox1I%3D
LOW Unpinned Actions Full Length Commit SHA /main.yml: 18
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: 1uTukcC5IaLU9vJWnDHn06jeikk%3D
LOW Unpinned Actions Full Length Commit SHA /main.yml: 43
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: cS8vtMndrfoWhrhCmk7CGJhHWM4%3D
LOW Unpinned Actions Full Length Commit SHA /main.yml: 37
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: hyh11wM4MVYog4iucIyX1aM92Ds%3D
LOW Unpinned Actions Full Length Commit SHA /main.yml: 31
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: KPD4GeF815zXtDCO1%2FbQvDSPFzU%3D
LOW Unpinned Actions Full Length Commit SHA /pypi.yml: 47
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: PCDeOMjvldAgPCSrMHwhGT%2BNlmQ%3D
LOW Unpinned Actions Full Length Commit SHA /live_tests_functions.yaml: 35
detailsPinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help...
ID: N%2FwQRYiNUEJMrlhrk3fdOS5bqY8%3D

@sg-s sg-s merged commit 5a89c54 into main Jun 23, 2025
10 of 12 checks passed
@sg-s sg-s deleted the docking-bugfix branch June 23, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants