Skip to content

Get poses #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

Get poses #265

merged 2 commits into from
Jul 7, 2025

Conversation

sg-s
Copy link
Collaborator

@sg-s sg-s commented Jul 7, 2025

No description provided.

@sg-s sg-s requested a review from a team as a code owner July 7, 2025 23:53
@sg-s sg-s self-assigned this Jul 7, 2025
@sg-s sg-s requested a review from Copilot July 7, 2025 23:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new method to aggregate docked poses into a LigandSet and updates the tutorial to demonstrate its usage.

  • Adds get_poses to collect all SDF docked poses into a LigandSet
  • Updates imports in docking.py to include LigandSet
  • Revises tutorial docs to show how to retrieve and save poses

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/drug_discovery/docking.py Added get_poses method and adjusted imports
docs/dd/tutorial/docking.md Updated tutorial section to use get_poses example
Comments suppressed due to low confidence (3)

src/drug_discovery/docking.py:96

  • [nitpick] The loop variable name file shadows the built-in. Consider renaming it to file_path for clarity and to avoid masking built-ins.
        for file in file_paths:

src/drug_discovery/docking.py:87

  • Add unit tests for get_poses, covering both the case where SDF results exist and where get_results returns None, to ensure correct behavior.
    def get_poses(self) -> LigandSet | None:

docs/dd/tutorial/docking.md:162

  • The example does not indicate that get_poses can return None if no results are available. Either update the doc to mention handling of the None case or change the method to always return an empty LigandSet.
poses = sim.docking.get_poses()

@@ -84,6 +84,20 @@ def show_poses(self):
)
JupyterViewer.visualize(html_content)

Copy link
Preview

Copilot AI Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] For consistency with other public methods in this class, consider adding a @beartype decorator to enforce the declared signature at runtime.

Suggested change
@beartype

Copilot uses AI. Check for mistakes.

@sg-s sg-s merged commit 44e95ec into main Jul 7, 2025
11 of 13 checks passed
@sg-s sg-s deleted the get-poses branch July 7, 2025 23:55
@checkmarx-do
Copy link

Logo
Checkmarx One – Scan Summary & Details51340c1d-1d62-45a6-9769-417f9c37f47f

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants