fix(io): Add robust symlink cleanup to prevent resource leakage #367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
__enter__/__exit__) toiovecandioringclasses for Pythonic resource managementatexithandler to clean up orphaned symlinks on normal process exitclose()methods with idempotent behavior for manual cleanupRelated Issue
Fixes #334 - Shared memory leakage due to symlinks not being properly deleted
Changes
The
iovecclass creates symlinks in/3fs-virt/iovs/that point to shared memory. Previously, cleanup only happened in__del__, which is unreliable in Python (not guaranteed to run, timing issues, exception handling problems).This PR improves cleanup reliability by:
with make_iovec(...) as iov:for automatic cleanupExample usage:
Test plan
__del__🤖 Generated with Claude Code