Add pyproject.toml for PEP 518 build system compliance #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a pyproject.toml file to specify build-system requirements, addressing the issue of missing build requirements documentation. The pyproject.toml specifies: - Build dependencies: setuptools, wheel, torch, packaging - Project metadata including description, authors, classifiers - Dynamic version reading from deep_gemm.__version__ - Package data configuration for include files This enables proper isolation of build dependencies and makes the package compatible with modern Python packaging tools (pip, build, etc.) that expect PEP 518 compliance. Fixes deepseek-ai#207 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
pyproject.tomlfile to address #207 (Missing build requirements documentation).Changes:
pyproject.tomlspecifying build-system requirements per PEP 518setuptools>=61.0,wheel,torch>=2.0.0,packagingdeep_gemm.__version__Benefits
pyproject.tomlfor build isolationsetup.pyis being phased out in favor of declarativepyproject.tomlTest Plan
pip install .works correctly with build isolationpython -m buildproduces correct wheelsetup.pyfunctionality remains intactFixes #207
🤖 Generated with Claude Code