Skip to content

test: update Bedrock tests with ComponentInfo #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Jul 4, 2025

Related Issues

Tests in experimental are failing (https://github.com/deepset-ai/haystack-experimental/actions/runs/16069230738/job/45349882428?pr=328) after we released a new version of Bedrock, which includes deepset-ai/haystack-core-integrations#2042

Proposed Changes:

  • align Bedrock experimental tests to those in core-integrations
  • unrelated: I'm also updating transformers version to keep it aligned with Haystack

How did you test it?

CI

Checklist

@coveralls
Copy link

coveralls commented Jul 4, 2025

Pull Request Test Coverage Report for Build 16069728364

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.671%

Totals Coverage Status
Change from base Build 16062935511: 0.0%
Covered Lines: 1448
Relevant Lines: 1633

💛 - Coveralls

@anakin87 anakin87 marked this pull request as ready for review July 4, 2025 08:46
@anakin87 anakin87 requested a review from a team as a code owner July 4, 2025 08:46
@anakin87 anakin87 requested review from vblagoje and davidsbatista and removed request for a team July 4, 2025 08:46
Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anakin87 anakin87 merged commit 5895cfc into main Jul 4, 2025
8 checks passed
@anakin87 anakin87 deleted the bedrock-component-info-update branch July 4, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants