-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update component registration to use new class reference #8715
Conversation
This fixed my issue with VS Code 👍 |
@kaqmak Hi! Thanks for this, we may decide to merge. But before, I would like to ask you to fix format first (see contributing guidelines). |
6a2b69e
to
b1dede4
Compare
b1dede4
to
c6639af
Compare
Hi @mpangrazzi . Thanks for the heads up. I believe formatting checks out now. |
All that should be left is to make a release note so that the Github tests can fully run https://github.com/deepset-ai/haystack/blob/main/CONTRIBUTING.md#release-notes |
c6639af
to
3318a82
Compare
Done. |
The pyright language server is now able to resolve the import and provide completions for the component.
3318a82
to
664d975
Compare
Pull Request Test Coverage Report for Build 12990031396Details
💛 - Coveralls |
The pyright language server is now able to resolve the import and provide completions for the component.
Related Issues
Proposed Changes:
Reuse of the name of the newly created class caused a type error and the type checker did not recognize the parameters. Renaming the newly created class to
new_class
seems to fix the problem.How did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
and added!
in case the PR includes breaking changes.