Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update component registration to use new class reference #8715

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

kaqmak
Copy link
Contributor

@kaqmak kaqmak commented Jan 13, 2025

The pyright language server is now able to resolve the import and provide completions for the component.

Related Issues

Proposed Changes:

Reuse of the name of the newly created class caused a type error and the type checker did not recognize the parameters. Renaming the newly created class to new_class seems to fix the problem.

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@kaqmak kaqmak requested a review from a team as a code owner January 13, 2025 14:27
@kaqmak kaqmak requested review from mpangrazzi and removed request for a team January 13, 2025 14:27
@CLAassistant
Copy link

CLAassistant commented Jan 13, 2025

CLA assistant check
All committers have signed the CLA.

@lbux
Copy link
Contributor

lbux commented Jan 14, 2025

This fixed my issue with VS Code 👍

@mpangrazzi
Copy link
Contributor

@kaqmak Hi! Thanks for this, we may decide to merge. But before, I would like to ask you to fix format first (see contributing guidelines).

@kaqmak kaqmak force-pushed the fix/component_type branch from 6a2b69e to b1dede4 Compare January 21, 2025 19:47
@github-actions github-actions bot added the type:documentation Improvements on the docs label Jan 21, 2025
@kaqmak kaqmak force-pushed the fix/component_type branch from b1dede4 to c6639af Compare January 21, 2025 19:49
@kaqmak
Copy link
Contributor Author

kaqmak commented Jan 21, 2025

@kaqmak Hi! Thanks for this, we may decide to merge. But before, I would like to ask you to fix format first (see contributing guidelines).

Hi @mpangrazzi . Thanks for the heads up. I believe formatting checks out now.

@lbux
Copy link
Contributor

lbux commented Jan 22, 2025

All that should be left is to make a release note so that the Github tests can fully run https://github.com/deepset-ai/haystack/blob/main/CONTRIBUTING.md#release-notes

@kaqmak kaqmak force-pushed the fix/component_type branch from c6639af to 3318a82 Compare January 22, 2025 20:21
@kaqmak kaqmak requested a review from a team as a code owner January 22, 2025 20:21
@kaqmak kaqmak requested review from dfokina and removed request for a team January 22, 2025 20:21
@kaqmak
Copy link
Contributor Author

kaqmak commented Jan 22, 2025

All that should be left is to make a release note so that the Github tests can fully run https://github.com/deepset-ai/haystack/blob/main/CONTRIBUTING.md#release-notes

Done.

The pyright language server is now able to resolve the import and provide completions for the component.
@kaqmak kaqmak force-pushed the fix/component_type branch from 3318a82 to 664d975 Compare January 27, 2025 08:00
@coveralls
Copy link
Collaborator

coveralls commented Jan 27, 2025

Pull Request Test Coverage Report for Build 12990031396

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.328%

Totals Coverage Status
Change from base Build 12987399246: 0.0%
Covered Lines: 8857
Relevant Lines: 9698

💛 - Coveralls

@mpangrazzi mpangrazzi enabled auto-merge (squash) January 27, 2025 13:51
@mpangrazzi mpangrazzi merged commit 0e6d2a4 into deepset-ai:main Jan 27, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:core type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyright type check breaks with version 2.8.0
5 participants