Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin numba>=0.54.0 in the test environment #8773

Merged
merged 1 commit into from
Jan 27, 2025
Merged

ci: pin numba>=0.54.0 in the test environment #8773

merged 1 commit into from
Jan 27, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Jan 27, 2025

Related Issues

Proposed Changes:

  • pin numba in the dependencies of the test environment, to help uv resolve the dependency tree.

How did you test it?

Local tests:

  • hatch env prune; hatch -e test shell fails on Python 3.10 and Ubuntu with the old pyproject.
  • It works when introducing the pin.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jan 27, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 27, 2025

Pull Request Test Coverage Report for Build 12985275943

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.328%

Totals Coverage Status
Change from base Build 12948411569: 0.0%
Covered Lines: 8857
Relevant Lines: 9698

💛 - Coveralls

@anakin87 anakin87 marked this pull request as ready for review January 27, 2025 08:54
@anakin87 anakin87 requested a review from a team as a code owner January 27, 2025 08:54
@anakin87 anakin87 requested review from davidsbatista and removed request for a team January 27, 2025 08:54
@davidsbatista
Copy link
Contributor

nice! I will keep this command in mind uv tree --invert, it helped in solving this issue

@anakin87 anakin87 merged commit 0ac47b0 into main Jan 27, 2025
30 of 31 checks passed
@anakin87 anakin87 deleted the pin-numba branch January 27, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hatch Test Environment Dependency Resolution Fails for Python 3.10+
3 participants