-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add outputs_to_string
to Tool and ComponentTool
#9152
Conversation
Pull Request Test Coverage Report for Build 14193875653Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had an initial look...
Please fix the mypy errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is room for future improvements for everything related to Agent
.
However, this PR is good to go.
@anakin87 what ideas do you have for future improvements? |
Related Issues
Proposed Changes:
Adds
outputs_to_string
to Tool and ComponentTool to allow users to customize how the output of a Tool should be converted into a string so that it can be provided back to the ChatGenerator in a ChatMessage.If
outputs_to_string
is not provided a default converter is used within ToolInvoker. The default handler uses the current default behavior.How did you test it?
Updated tests.
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
and added!
in case the PR includes breaking changes.