feat: add schema cmds #37
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| // Copyright 2024 Defense Unicorns | ||
| // SPDX-License-Identifier: AGPL-3.0-or-later OR LicenseRef-Defense-Unicorns-Commercial | ||
|
|
||
| package cmd | ||
|
|
||
| import ( | ||
| "os" | ||
|
|
||
| helmSchema "github.com/defenseunicorns/uds-pk/src/schema" | ||
| "github.com/spf13/cobra" | ||
| "github.com/zarf-dev/zarf/src/pkg/message" | ||
| ) | ||
|
|
||
| func schema() *cobra.Command { | ||
| var schemaCmd = &cobra.Command{ | ||
| Use: "schema", | ||
| Aliases: []string{"s"}, | ||
| Short: "Generate and check JSON schemas for values.yaml files.", | ||
| } | ||
|
|
||
| return schemaCmd | ||
|
|
||
| } | ||
|
Comment on lines
+22
to
+23
|
||
|
|
||
| func generateSchemas() *cobra.Command { | ||
| var baseDir string | ||
|
|
||
| generateSchemasCmd := &cobra.Command{ | ||
| Use: "generate", | ||
| Aliases: []string{"g"}, | ||
| Short: "Generate JSON schemas for all values.yaml files in a base directory.", | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| if err := helmSchema.GenerateSchemas(baseDir); err != nil { | ||
| message.WarnErr(err, "Failed to generate schemas") | ||
| } | ||
| return nil | ||
| }, | ||
| } | ||
|
|
||
| generateSchemasCmd.Flags().StringVarP(&baseDir, "base-dir", "b", "./charts", "Base directory to search for values.yaml files") | ||
| return generateSchemasCmd | ||
| } | ||
|
|
||
| func checkSchemas() *cobra.Command { | ||
| var baseDir string | ||
|
|
||
| checkSchemasCmd := &cobra.Command{ | ||
| Use: "validate", | ||
| Aliases: []string{"v"}, | ||
| Short: "Check if JSON schemas are up-to-date for all values.yaml files in a base directory.", | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| if err := helmSchema.ValidateSchemas(baseDir); err != nil { //TODO(ewyles) -- Renamed this to ValidateSchemas to match the cli verb name | ||
| message.WarnErrf(err, "Failed to check schemas for %s: \n%s", baseDir, err.Error()) | ||
| rootCmd.SilenceUsage = true | ||
| os.Exit(1) | ||
| } | ||
| return nil | ||
| }, | ||
| } | ||
|
|
||
| checkSchemasCmd.Flags().StringVarP(&baseDir, "base-dir", "b", "./charts", "Base directory to search for values.yaml files") | ||
| return checkSchemasCmd | ||
| } | ||
|
|
||
| func init() { | ||
| schemaCmd := schema() | ||
|
|
||
| schemaCmd.AddCommand(generateSchemas()) | ||
| schemaCmd.AddCommand(checkSchemas()) | ||
| rootCmd.AddCommand(schemaCmd) | ||
|
Comment on lines
+68
to
+70
Contributor
There was a problem hiding this comment. we should be consistent with the patterns we use for this (see how the other pk commands are)
Contributor
Author
There was a problem hiding this comment. Sure that's an easy enough change. |
||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this? The package is 7 yrs old
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldnt
needit i'll look at finding a different way or library.