feat: granular reverts (#45)

* refactor: set params_first_multi for multiline_func_header in forge fmt

* feat: avoid using duplicate errors

* test: update expected errors in unit tests

* style: remove dot from @notice tags

foundry.toml

@@ -5,7 +5,7 @@ bracket_spacing = false
 int_types = 'long'
 quote_style = 'single'
 number_underscore = 'thousands'
-multiline_func_header = 'params_first'
+multiline_func_header = 'params_first_multi'
 sort_imports = true
 
 [profile.default]

solidity/contracts/Oracle.sol

@@ -117,12 +117,12 @@ contract Oracle is IOracle {
 
     // The caller must be the proposer, unless the response is coming from a dispute module
     if (msg.sender != _response.proposer && msg.sender != address(_request.disputeModule)) {
-      revert Oracle_InvalidResponseBody();
+      revert Oracle_InvalidProposer();
     }
 
     // Can't propose the same response twice
     if (responseCreatedAt[_responseId] != 0) {
-      revert Oracle_InvalidResponseBody();
+      revert Oracle_ResponseAlreadyProposed();
     }
 
     if (finalizedAt[_requestId] != 0) {
@@ -153,11 +153,11 @@ contract Oracle is IOracle {
     }
 
     if (_dispute.proposer != _response.proposer) {
-      revert Oracle_InvalidDisputeBody();
+      revert Oracle_InvalidProposer();
     }
 
     if (_dispute.disputer != msg.sender) {
-      revert Oracle_InvalidDisputeBody();
+      revert Oracle_InvalidDisputer();
     }
 
     if (finalizedAt[_requestId] != 0) {

solidity/interfaces/IOracle.sol

@@ -165,6 +165,21 @@ interface IOracle {
    */
   error Oracle_InvalidDispute();
 
+  /**
+   * @notice Thrown when response has been already proposed
+   */
+  error Oracle_ResponseAlreadyProposed();
+
+  /**
+   * @notice Thrown when the proposer is invalid
+   */
+  error Oracle_InvalidProposer();
+
+  /**
+   * @notice Thrown when the disputer is invalid
+   */
+  error Oracle_InvalidDisputer();
+
   /*///////////////////////////////////////////////////////////////
                               ENUMS
   //////////////////////////////////////////////////////////////*/

solidity/test/unit/Oracle.t.sol

@@ -481,7 +481,7 @@ contract Oracle_Unit_ProposeResponse is BaseTest {
     oracle.mock_setRequestCreatedAt(_getId(mockRequest), uint128(block.number));
 
     // Check: revert?
-    vm.expectRevert(IOracle.Oracle_InvalidResponseBody.selector);
+    vm.expectRevert(IOracle.Oracle_InvalidProposer.selector);
 
     // Test: try to propose a response from a random address
     vm.prank(_caller);
@@ -500,7 +500,7 @@ contract Oracle_Unit_ProposeResponse is BaseTest {
     oracle.proposeResponse(mockRequest, mockResponse);
 
     // Check: revert?
-    vm.expectRevert(IOracle.Oracle_InvalidResponseBody.selector);
+    vm.expectRevert(IOracle.Oracle_ResponseAlreadyProposed.selector);
 
     // Test: try to propose the same response again
     vm.prank(proposer);
@@ -576,7 +576,7 @@ contract Oracle_Unit_DisputeResponse is BaseTest {
     oracle.mock_setRequestCreatedAt(_getId(mockRequest), uint128(block.number));
 
     // Check: revert?
-    vm.expectRevert(IOracle.Oracle_InvalidDisputeBody.selector);
+    vm.expectRevert(IOracle.Oracle_InvalidProposer.selector);
 
     mockDispute.proposer = _otherProposer;
 
@@ -606,7 +606,7 @@ contract Oracle_Unit_DisputeResponse is BaseTest {
     vm.assume(_caller != disputer);
 
     // Check: revert?
-    vm.expectRevert(IOracle.Oracle_InvalidDisputeBody.selector);
+    vm.expectRevert(IOracle.Oracle_InvalidDisputer.selector);
 
     // Test: try to dispute the response again
     vm.prank(_caller);