fix: clean if

defi-wonderland · Jul 12, 2024 · cd86332 · cd86332
1 parent 1b9a059
commit cd86332
Showing 1 changed file with 4 additions and 13 deletions.
diff --git a/solidity/contracts/Oracle.sol b/solidity/contracts/Oracle.sol
@@ -134,22 +134,13 @@ contract Oracle is IOracle {
       revert Oracle_InvalidDisputeBody();
     }
 
-    if (_dispute.disputer != msg.sender) {
+    if (
+      _dispute.disputer != msg.sender || createdAt[_dispute.requestId] == 0 || finalizedAt[_response.requestId] != 0
+        || disputeOf[_response.requestId] != bytes32(0)
+    ) {
       revert Oracle_InvalidDisputeBody();
     }
 
-    if (createdAt[_dispute.requestId] == 0) {
-      revert Oracle_InvalidDisputeBody();
-    }
-
-    if (finalizedAt[_response.requestId] != 0) {
-      revert Oracle_AlreadyFinalized(_response.requestId);
-    }
-
-    if (disputeOf[_dispute.responseId] != bytes32(0)) {
-      revert Oracle_ResponseAlreadyDisputed(_dispute.responseId);
-    }
-
     _participants[_response.requestId] = abi.encodePacked(_participants[_response.requestId], msg.sender);
     disputeStatus[_disputeId] = DisputeStatus.Active;
     disputeOf[_dispute.responseId] = _disputeId;