feat: checks createAt #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xShaito
previously approved these changes
Jul 26, 2024
0xJabberwock
requested changes
Jul 26, 2024
0xJabberwock
requested changes
Jul 31, 2024
0xShaito
requested changes
Aug 3, 2024
0xJabberwock
requested changes
Aug 5, 2024
solidity/test/unit/Oracle.t.sol
Outdated
Comment on lines
929
to
931
| function test_finalize_revertsIfInvalidRequest() public { | ||
| oracle.mock_setRequestCreatedAt(_getId(mockRequest), 0); | ||
| vm.expectRevert(IOracle.Oracle_InvalidRequestBody.selector); | ||
| vm.expectRevert(IOracle.Oracle_InvalidResponseBody.selector); |
There was a problem hiding this comment.
The test case name and the expected reversion don't seem to match.
0xShaito
requested changes
Aug 6, 2024
0xJabberwock
requested changes
Aug 6, 2024
solidity/test/unit/Validator.t.sol
Outdated
Comment on lines
189
to
194
| contract ValidatorValidateResponseAndDispute is BaseTest { | ||
| function test_validateResponseAndDispute() public { | ||
| (bytes32 responseId, bytes32 disputeId) = | ||
| validator.validateResponseAndDispute(mockRequest, mockResponse, mockDispute); | ||
| assertEq(responseId, keccak256(abi.encode(mockResponse))); | ||
| assertEq(disputeId, keccak256(abi.encode(mockDispute))); |
There was a problem hiding this comment.
All the test cases of the above kind should be kept within Validator.t.sol, as we're still returning IDs in the validation functions.
Actually, it would make sense to duplicate all the test cases moved to ValidatorLib.t.sol in order to make sure that the library is properly being called.
There was a problem hiding this comment.
I did it for not duplicate test logic in the contracts, even so, i can do it again all those tests.
0xJabberwock
requested changes
Aug 6, 2024
0xShaito
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-18