refactor: move module access controller #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing tests. |
xorsal
approved these changes
Nov 14, 2024
| @@ -10,7 +10,7 @@ import {IRequestModule} from '../interfaces/modules/request/IRequestModule.sol'; | |||
| import {IResolutionModule} from '../interfaces/modules/resolution/IResolutionModule.sol'; | |||
| import {IResponseModule} from '../interfaces/modules/response/IResponseModule.sol'; | |||
| import {ValidatorLib} from '../libraries/ValidatorLib.sol'; | |||
| import {OracleAccessController} from './OracleAccessController.sol'; | |||
| import {OracleAccessController} from './access/OracleAccessController.sol'; | |||
There was a problem hiding this comment.
Nice, I didn't like the files thrown in contracts/
| if (!ORACLE.isAccessModuleApproved(_accessControl.user, _accessModule)) { | ||
| revert ModuleAccessController_AccessModuleNotApproved(); | ||
| } | ||
| _hasAccess(_accessModule, _typehash, _params, _accessControl); |
There was a problem hiding this comment.
#55 will impact here.
Similarly in OracleAccessController.
Comment on lines
+9
to
+10
| abstract contract ModuleAccessController is IModuleAccessController, CommonAccessController, Module { | ||
| constructor(IOracle _oracle) Module(_oracle) {} |
There was a problem hiding this comment.
Why does ModuleAccessController inherit from Module, if it is not a module itself? In my opinion, it would make more sense to make the latter inherit from the former, such that:
Oracle is OracleAccessControllerandModule is ModuleAccessController, whileMyAccessModule is Module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes OPT-530