Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding mint address validation at create #17

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Conversation

wei3erHase
Copy link
Member

@wei3erHase wei3erHase commented Oct 4, 2024

Fixes HAL-002

Description

After the user invokes the process_init entry point, they need to invoke the process_create entry point to store the necessary information to participate in the token locking process.

A piece of information that the user has to provide is the source token account, where the tokens will be subtracted to participate.

The mentioned token account is not validated to be a token account corresponding to the L3 token, which is expected to be the token used.

As a result, any user can create a vesting_account that does with any token different than L3 token.

The L3 team mentioned that this situation does not represent a risk, since the information on chain will be used on an off-chain process.

However, it is considered a good practice to restrict the functionalities of a program used in production to narrow down the attack surface in order to prevent unexpected behaviors.

@wei3erHase wei3erHase merged commit a0e0289 into dev Oct 4, 2024
1 of 2 checks passed
@wei3erHase wei3erHase deleted the fix/validate-mint branch October 4, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant