Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: production release (missing tests) #21

Merged
merged 14 commits into from
Oct 9, 2024
Merged

chore: production release (missing tests) #21

merged 14 commits into from
Oct 9, 2024

Commits on Oct 2, 2024

  1. Configuration menu
    Copy the full SHA
    d247ea4 View commit details
    Browse the repository at this point in the history
  2. fix: npm workflows (#15)

    0xGorilla authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    22b19d4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    175303f View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. fix: cargo fmt (#18)

    wei3erHase authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8dbf3fc View commit details
    Browse the repository at this point in the history
  2. fix: validated lock time deltas (3mth,6,9,12) (#19)

    separating #13 into different PRs/commits
    fixing the time-deltas to be the updated (shorter) ones: 3, 6, 9, 12
    months
    wei3erHase authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d4f9644 View commit details
    Browse the repository at this point in the history
  3. fix: validate system accounts (#20)

    Fixes HAL-003
    
    > ## Description
    > In order to participate in a token locking process, a user needs to
    first invoke the process_init entry point.
    > 
    > This entry point will create an account with the necessary size to
    store the information provided in the next step of the process,
    process_create .
    > 
    > The current version of this program is not checking that the provided
    System Program and Rent Sysvar accounts corresponds to the correct
    accounts, provided by the Solana Rust SDK.
    > 
    > Although there was not risk identified due to this lack of
    restrictions, it is a good practice to implement this validations to
    prevent any unexpected attack vector that might appear later.
    wei3erHase authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7e7cde4 View commit details
    Browse the repository at this point in the history
  4. feat: adding mint address validation at create (#17)

    Fixes HAL-002
    
    > ## Description
    > After the user invokes the process_init entry point, they need to
    invoke the process_create entry point to store the necessary information
    to participate in the token locking process.
    > 
    > A piece of information that the user has to provide is the source
    token account, where the tokens will be subtracted to participate.
    > 
    > The mentioned token account is not validated to be a token account
    corresponding to the L3 token, which is expected to be the token used.
    > 
    > As a result, any user can create a vesting_account that does with any
    token different than L3 token.
    > 
    > The L3 team mentioned that this situation does not represent a risk,
    since the information on chain will be used on an off-chain process.
    > 
    > However, it is considered a good practice to restrict the
    functionalities of a program used in production to narrow down the
    attack surface in order to prevent unexpected behaviors.
    wei3erHase authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a0e0289 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Configuration menu
    Copy the full SHA
    d520202 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f8b51b3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c5ca462 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Configuration menu
    Copy the full SHA
    6c0fd6d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8420c98 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Configuration menu
    Copy the full SHA
    37c5f80 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Configuration menu
    Copy the full SHA
    f01d871 View commit details
    Browse the repository at this point in the history