-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: production release (missing tests) #21
Merged
Merged
Commits on Oct 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d247ea4 - Browse repository at this point
Copy the full SHA d247ea4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22b19d4 - Browse repository at this point
Copy the full SHA 22b19d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 175303f - Browse repository at this point
Copy the full SHA 175303fView commit details
Commits on Oct 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8dbf3fc - Browse repository at this point
Copy the full SHA 8dbf3fcView commit details -
fix: validated lock time deltas (3mth,6,9,12) (#19)
separating #13 into different PRs/commits fixing the time-deltas to be the updated (shorter) ones: 3, 6, 9, 12 months
Configuration menu - View commit details
-
Copy full SHA for d4f9644 - Browse repository at this point
Copy the full SHA d4f9644View commit details -
fix: validate system accounts (#20)
Fixes HAL-003 > ## Description > In order to participate in a token locking process, a user needs to first invoke the process_init entry point. > > This entry point will create an account with the necessary size to store the information provided in the next step of the process, process_create . > > The current version of this program is not checking that the provided System Program and Rent Sysvar accounts corresponds to the correct accounts, provided by the Solana Rust SDK. > > Although there was not risk identified due to this lack of restrictions, it is a good practice to implement this validations to prevent any unexpected attack vector that might appear later.
Configuration menu - View commit details
-
Copy full SHA for 7e7cde4 - Browse repository at this point
Copy the full SHA 7e7cde4View commit details -
feat: adding mint address validation at create (#17)
Fixes HAL-002 > ## Description > After the user invokes the process_init entry point, they need to invoke the process_create entry point to store the necessary information to participate in the token locking process. > > A piece of information that the user has to provide is the source token account, where the tokens will be subtracted to participate. > > The mentioned token account is not validated to be a token account corresponding to the L3 token, which is expected to be the token used. > > As a result, any user can create a vesting_account that does with any token different than L3 token. > > The L3 team mentioned that this situation does not represent a risk, since the information on chain will be used on an off-chain process. > > However, it is considered a good practice to restrict the functionalities of a program used in production to narrow down the attack surface in order to prevent unexpected behaviors.
Configuration menu - View commit details
-
Copy full SHA for a0e0289 - Browse repository at this point
Copy the full SHA a0e0289View commit details
Commits on Oct 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d520202 - Browse repository at this point
Copy the full SHA d520202View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8b51b3 - Browse repository at this point
Copy the full SHA f8b51b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5ca462 - Browse repository at this point
Copy the full SHA c5ca462View commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6c0fd6d - Browse repository at this point
Copy the full SHA 6c0fd6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8420c98 - Browse repository at this point
Copy the full SHA 8420c98View commit details
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 37c5f80 - Browse repository at this point
Copy the full SHA 37c5f80View commit details
Commits on Oct 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f01d871 - Browse repository at this point
Copy the full SHA f01d871View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.