Editor: Update Spine plugin with GUI template layout changes #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matgis
commented
Dec 5, 2024
| :spine-bones (s/maybe {s/Keyword s/Any}) | ||
| :spine-scene-scene (s/maybe {s/Keyword s/Any}) | ||
| :spine-scene-pb (s/maybe {s/Keyword s/Any})}}) | ||
|
|
There was a problem hiding this comment.
These are already defined in editor.gui.
| (for [[name path] spine-scene-name+paths] | ||
| (let [spine-scene-resource (workspace/resolve-resource resource path)] | ||
| (g/make-nodes graph-id [spine-scene [SpineSceneNode :name name :spine-scene spine-scene-resource]] | ||
| (attach-spine-scene self spine-scenes-node spine-scene))))))) |
There was a problem hiding this comment.
Indentation + unified code paths for old-spine-scenes and new-spine-scenes. Removed remnant use of (g/declared-property-labels gui/ResourceNode).
| @@ -369,8 +370,7 @@ | |||
| :custom-type 0 | |||
| :output-node-type (:node-type info) | |||
| :output-custom-type (:custom-type info) | |||
| :deprecated true | |||
| :defaults gui/visual-base-node-defaults})] | |||
| :deprecated true})] | |||
There was a problem hiding this comment.
Cleanup: :defaults is already in info.
matgis
force-pushed
the
gui-layout-override-refactor
branch
from
c2c1fcd to
81d6e79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated editor plugin with corresponding changes from defold/defold#9884.