Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week3 submission #22

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Week3 submission #22

wants to merge 8 commits into from

Conversation

58DevOggu
Copy link

For week1 challenge review

@58DevOggu 58DevOggu changed the title Week1 - Challenge Week2 Submission and Week1 - Challenge Aug 21, 2022
@58DevOggu 58DevOggu changed the title Week2 Submission and Week1 - Challenge Week3 submission - Challenge Sep 3, 2022
@58DevOggu 58DevOggu changed the title Week3 submission - Challenge Week3 submission Sep 3, 2022
@frasermarlow
Copy link

I see you swapped out
"http://localstack:4566"
for
"http://host.docker.internal:4566"
Which is causing the tests to fail. Was this required on your end to get the pipelines to run locally?

@frasermarlow
Copy link

frasermarlow commented Sep 5, 2022

Also one error I ran into was simply this:
redis.exceptions.DataError: Invalid input of type: 'datetime'. Convert to a bytes, string, int or float first.
So I changed line 60 from
context.resources.redis.put_data(aggregation.date, str(aggregation.high))
to
context.resources.redis.put_data(str(aggregation.date), str(aggregation.high))
And now the pipeline will run successfully.

@ypotier
Copy link

ypotier commented Sep 6, 2022

Same comment as fraser. After the changes, the tests can run successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants