Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(restapi): add ability to use any arbitrary postgres DB #162

Closed
wants to merge 6 commits into from

Conversation

arschles
Copy link
Member

not just RDS

Fixes #141
Closes #158

@arschles arschles added this to the v2.2 milestone Jul 12, 2016
@arschles arschles self-assigned this Jul 12, 2016
@krancour
Copy link

@arschles what database does this use out-of-the-box? i.e. controller, by default, uses the on-cluster postgres in deis-database. What does this use? I'm asking because I think we should be conscious of making off-cluster db configuration as easy for this as it is for the controller. (i.e. easily done via generate_params.toml).

@arschles
Copy link
Member Author

@krancour this uses RDS out of the box (as of a9085d8), and in that case requires only the WORKFLOW_MANAGER_API_RDS_REGION env var. It gets the rest of the DB connection information from the AWS API.

Also, sidenote - this component has no helm chart - everything is deployed & configured via deis itself.

@arschles
Copy link
Member Author

arschles commented Jul 18, 2016

Also note that in the in-cluster case, this patch will make wfm-api require a secret, so we'll have to add a helm chart or similar

@arschles
Copy link
Member Author

arschles commented Jul 18, 2016

Removing from the 2.2 milestone, as it was never a necessary deliverable for that milestone

@mboersma
Copy link
Member

mboersma commented Jul 5, 2017

I'm closing this PR since it's a year old 🎂, but @arschles please re-open if the code here is still relevant.

@mboersma mboersma closed this Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants