feat(server.go,handlers/clusters_age_handler.go): design the cluster age REST API interface #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm punting this to beta4 |
This was referenced Apr 25, 2016
arschles
force-pushed
the
cluster-age
branch
2 times, most recently
from
576207b to
3aa75b1
Compare
| // with parameters that would create a filter that is guaranteed to produce no results. One such | ||
| // "impossible" query is a "created before" time is after a "created " time that is after (i.e. | ||
| // an impossible filter). One | ||
| // example of an impossible |
There was a problem hiding this comment.
I think the last sentence fragment here is probably superfluous.
|
LGTM, though I'd like to walk through the 4 documented error types, just so I'm 100% on board (I know you spent a lot of thought teasing those out, it'd be nice to catch up with the fruit of your labor). |
| return fmt.Sprintf("%s (%s)", k.key, k.time) | ||
| } | ||
|
|
||
| // ErrImpossibleFilter is the error returned when a called tries to create a new ClusterAgeFilter |
| package main | ||
|
|
||
| import ( | ||
| // "bytes" |
complete with tests at multiple layers and API documentationoo
| assert.NoErr(t, json.NewDecoder(resp.Body).Decode(&respEnvelope)) | ||
| assert.Equal(t, len(respEnvelope.Data), 1, "length of the clusters list") | ||
| assert.Equal(t, respEnvelope.Data[0].ID, cluster.ID, "returned cluster ID") | ||
| } |
There was a problem hiding this comment.
nit/not needed for this PR: looks like the only test 'gap' is validating the 400 Bad Request resp scenarios? (Although the data side appears covered in data/cluster_from_db_filter_by_age_test.go)
There was a problem hiding this comment.
yep that's right. I've added #85 to track the work to validate the error responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #60, #58 and #57
Fixes #44
Still TODO:
(*github.com/deis/workflow-manager-api/data/ClusterFromDB).FilterByAgeGET /:apiVersion/clusters/age?...endpointapi-architecture.md