add module property to package.json

[timelyportfolio]

Thanks so much for your incredbile work on searchjs. I plan to integrate into parcoord-es.

rollup and the module property

I struggled with simple import { matchArray } from 'searchjs in an outside project, which generally works as expected. I discovered through this StackOverflow discussion that the problem was coming from rollup and a missing module property in package.json. Adding the module property resolved my issue.

[codecov-io]

Codecov Report

Merging #43 into master will decrease coverage by 0.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   98.11%   97.56%   -0.56%     
==========================================
  Files           3        3              
  Lines         159      123      -36     
==========================================
- Hits          156      120      -36     
  Misses          3        3

[deitch]

Thanks for a simple yet effective PR, @timelyportfolio .

CI passes, so all looks good.

The Stack Overflow link is empty. Do you mind adding it? I would like to see the discussion there.

[deitch]

Also, probably need to bump package*.json patch number to publish it.

[timelyportfolio]

@deitch I added the link above but also it is here https://stackoverflow.com/questions/42708484/what-is-the-module-package-json-field-for. I spent a couple hours figuring out this one stinking line :) Happy to help in any way on such a great project.

searchjs is immensely helpful. If I get real ambitious, I'd eventually like to implement jsql in R.

[deitch]

I spent a couple hours figuring out this one stinking line :)

Isn't it always like that? Where was that line on twitter? "I hate software development, I hate software development, I hate software development, I hate software development, I hate software development, I hate software development... found the bug... it works... I love software development!!"

Happy to help in any way on such a great project

Thank you. I was thinking of moving this to its own org, and then doing implementations in Go, Rust, etc.

[deitch]

Looks like package-lock.json is out of date (sorely), can you bump that as well, and let's get this merged in? I know package.json will override, but still, good to get it "right".

[timelyportfolio]

@deitch I bumped package-lock.json version. As we are dreaming in this pull request, I'd also love to see a json schema for jsql, and if I get some time will work on that as well.

[deitch]

I'd also love to see a json schema for jsql

Like to see it as well. I think life gets pulled apart by being involved in many OSS projects. :-)

Not to mention actual consulting work for which I get paid and have obligations which I take seriously.

[deitch]

Published.