Skip to content

add Poetry instead of setuptools #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ftapajos
Copy link

@ftapajos ftapajos commented Mar 9, 2025

this pr substitutes setuptools for poetry and moves root snmp-server.py to the tested folder. This substitution yields the following failed tests, which concern me a bit:

======================================================= short test summary info ========================================================
FAILED snmp_server/tests/test_server.py::Test::test_counter32 - AssertionError: b'A\x02\x00\xff' != b'A\x01\xff'
FAILED snmp_server/tests/test_server.py::Test::test_counter64 - AssertionError: b'F\x02\x00\xff' != b'F\x01\xff'
FAILED snmp_server/tests/test_server.py::Test::test_gauge32 - AssertionError: b'B\x04\x00\x00\x00\x00' != b'B\x08\x00\x00\x00\x00\x00\x00\x00\x00'
FAILED snmp_server/tests/test_server.py::Test::test_integer - AssertionError: b'\x02\x04\x00\x00\x00\x00' != b'\x02\x08\x00\x00\x00\x00\x00\x00\x00\x00'
FAILED snmp_server/tests/test_server.py::Test::test_parse_asn1_length - AssertionError: 48225 != 12345678
FAILED snmp_server/tests/test_server.py::Test::test_timeticks - AssertionError: b'C\x02\x00\xff' != b'C\x01\xff'
FAILED snmp_server/tests/test_server.py::Test::test_write_asn1_length - AssertionError: b'\x81\x00\x80' != b'\x81\x80'
FAILED snmp_server/tests/test_server.py::Test::test_write_int - AssertionError: b'\x00\x80' != b'\x80'
FAILED snmp_server/tests/test_server.py::Test::test_write_tlv - AssertionError: b'\xff\x81\x00\x80value' != b'\xff\x81\x80value'
ERROR snmp_server/tests/test_plugin.py::test_request_replies_correctly
ERROR snmp_server/tests/test_plugin.py::test_dual_request_replies_correctly
ERROR snmp_server/tests/test_plugin.py::test_snmp_range_correctly
ERROR snmp_server/tests/test_plugin.py::test_snmp_walk
================================================ 9 failed, 19 passed, 4 errors in 0.10s ================================================

@delimitry delimitry self-requested a review March 24, 2025 23:28
@delimitry delimitry added the enhancement New feature or request label Mar 24, 2025
@delimitry
Copy link
Owner

Hi @ftapajos! Thank you!
I've found a problem, will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants