Increase Unit Test Coverage #456

falfaroc · 2025-02-13T18:28:08Z

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

Have you run format,vet & lint checks against your submission?
Have you made sure that the code compiles?
Did you run the unit & integration tests successfully?
Have you maintained at least 90% code coverage?
Have you commented your code, particularly in hard-to-understand areas
Have you done corresponding changes to the documentation
Did you run tests in a real Kubernetes cluster?
Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

- migration mitigates data races found during testing.

- Setting induced errors directly from test code was causing data races.

- use updates to gopowermax client.

- add -race flag to testing targets. - add clean as a separate target to speed up test execution.

…wermax into usr/spark/ut-svc-pkg

- Needed to regenerate pmaxclient.go after interface changed.

…wermax into usr/spark/ut-svc-pkg

- added funcs to remove pmax client from client cache after a test. - added func to remove replication capability from the cache after a test.

lukeatdell and others added 13 commits February 10, 2025 09:54

migrate snapCleaner global to svc struct member.

5bbc29a

- migration mitigates data races found during testing.

create admin clients for new service instances

cc031ab

Fix race condition in node_connectivity_checker

f8d37c5

use safe error injector func from gopowermax mock pkg

f443e85

- Setting induced errors directly from test code was causing data races.

Fix race condition in deletion worker

2182099

update gopowermax module version.

5853e49

- use updates to gopowermax client.

Added storeProbeStatus to fix race condition

8927281

refactor makefile for easier use.

8977ecf

- add -race flag to testing targets. - add clean as a separate target to speed up test execution.

Fix race condition with induced error global variables

4395e8d

Fix race conditions in metro.go

d190d29

fix race condition related to nvmeTCPtargets map access

24dcaa7

update gopowermax refs and module version

4819f78

Fix race condition when getting powermax client

2f3de9d

falfaroc changed the title ~~Usr/spark/ut svc pkg~~ Increase Unit Test Coverage Feb 13, 2025

lukeatdell changed the base branch from main to usr/spark/unit-test-improvements February 13, 2025 18:29

lukeatdell and others added 15 commits February 13, 2025 13:38

go mod tidy

a3353b9

adding some unit tests for mount.go

0e18ca0

Add tests for deletion_worker

c43c860

Reset sync time after test

5949783

Add tests thet increase coverage for node.go

5414f74

Merge branch 'usr/spark/ut-svc-pkg' of https://github.com/dell/csi-po…

381c449

…wermax into usr/spark/ut-svc-pkg

removing a test that is wip

4121763

inc coverage for setArrayConfigEnvs

0d48cc4

Improve migration test to 91.3%

a359524

Unit tests for csi_ctrl_to_node_connectivity.go file

d8c3153

Added Unit test for snap.go

4148266

add a couple tests for snap.go

0effc08

Added UTs for interfaces.go

ba8ca88

update mock package to active go.uber.org/mock/gomock

ea58eee

- Needed to regenerate pmaxclient.go after interface changed.

adding tests for controller.go

edcfff8

bharathsreekanth and others added 6 commits February 19, 2025 01:41

Refactor interfaces unit test

35c9d50

update gomock mod provider in other pkgs

fdd4afb

unit tests for node.go

7c2a5fe

Merge branch 'usr/spark/ut-svc-pkg' of https://github.com/dell/csi-po…

8c05757

…wermax into usr/spark/ut-svc-pkg

Add tests for service.go

da73130

add tests for createMetroVolume().

fd709d5

- added funcs to remove pmax client from client cache after a test. - added func to remove replication capability from the cache after a test.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Increase Unit Test Coverage #456

Increase Unit Test Coverage #456

falfaroc commented Feb 13, 2025

Increase Unit Test Coverage #456

Are you sure you want to change the base?

Increase Unit Test Coverage #456

Conversation

falfaroc commented Feb 13, 2025

Description

GitHub Issues

Checklist:

How Has This Been Tested?