Skip to content

Update CreateSnapshot to conform to CSI 1.6 Spec #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2025

Conversation

suryagupta4
Copy link
Contributor

@suryagupta4 suryagupta4 commented Jun 5, 2025

Description

This PR addresses the following CSI Spec test scenarios for CreateSnapshot:

  • should succeed when requesting to create a snapshot with already existing name and same source volume ID
  • should fail when requesting to create a snapshot with already existing name and different source volume ID
  • should succeed when creating snapshot with maximum-length name

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1896

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Executed SnapSuite (with and w/o Auth enabled) - cert-csi test snap --sc isilon --vsc isilon-snapclass

image

  • csi-sanity for CreateSnapshot - ./csi-sanity --csi.endpoint=unix:///root/csi.sock --ginkgo.focus='CreateSnapshot'

image

  • Executed Auth v2 e2e - all scenarios
    TestSnapshot:
    image

@suryagupta4 suryagupta4 self-assigned this Jun 5, 2025
@suryagupta4 suryagupta4 changed the title [WIP]: Update CreateSnapshot to conform to CSI 1.6 Spec Update CreateSnapshot to conform to CSI 1.6 Spec Jun 12, 2025
@suryagupta4 suryagupta4 marked this pull request as ready for review June 12, 2025 06:10
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/common/utils 0.00% (ø)
github.com/dell/csi-powerscale/service 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/common/utils/utils.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/controller.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/service.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerscale/common/utils/utils_test.go
  • github.com/dell/csi-powerscale/service/service_test.go

@suryagupta4 suryagupta4 merged commit 5a0ca6f into main Jun 13, 2025
6 checks passed
@suryagupta4 suryagupta4 deleted the usr/suryagupta4/createsnapshot-csi-spec-fix branch June 13, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants