Skip to content

Update Validate Volume Capabilities to conform to CSI 1.6 Spec #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

sakshi-garg1
Copy link
Contributor

@sakshi-garg1 sakshi-garg1 commented Jun 12, 2025

Description

This PR addresses the following CSI Spec test scenarios for Validate Volume Capabilities:

  • Controller Service ValidateVolumeCapabilities method should return appropriate values (no optional values added)

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1896

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran csi-sanity test
image
  • Ran cert-csi test
    image

@sakshi-garg1 sakshi-garg1 self-assigned this Jun 12, 2025
@sakshi-garg1 sakshi-garg1 marked this pull request as ready for review June 13, 2025 07:25
@sakshi-garg1 sakshi-garg1 changed the title [WIP]:Update Validate Volume Capabilities to conform to CSI 1.6 Spec Update Validate Volume Capabilities to conform to CSI 1.6 Spec Jun 13, 2025
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/service 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/service/controller.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@sakshi-garg1 sakshi-garg1 merged commit 6698ba9 into main Jun 16, 2025
6 checks passed
@sakshi-garg1 sakshi-garg1 deleted the fix_ValidateVolumeCapabilties_test branch June 16, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants