Skip to content

Implement NodeGetVolumeStats to conform to CSI 1.6 #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2025

Conversation

rishabhatdell
Copy link
Contributor

@rishabhatdell rishabhatdell commented Jun 24, 2025

Description

Enhancements to improve compliance with CSI Spec 1.6 and updated UTs

  • NodeGetVolumeStats should fail when no volume path is provided
  • NodeGetVolumeStats should fail when volume is not found
  • NodeGetVolumeStats should fail when volume does not exist on the specified path

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1896

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran csi-sanity for NodeGetVolumeStats
  • Ran cert-csi successfully

@rishabhatdell rishabhatdell changed the title Make Node Service NodeGetVolumeStats CSI 1.6 compliant Implement NodeGetVolumeStats to conform to CSI 1.6 #408 Jun 24, 2025
@rishabhatdell rishabhatdell changed the title Implement NodeGetVolumeStats to conform to CSI 1.6 #408 Implement NodeGetVolumeStats to conform to CSI 1.6 Jun 24, 2025
@rishabhatdell rishabhatdell marked this pull request as ready for review June 24, 2025 09:29
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/service 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/service/node.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerscale/service/node_test.go
  • github.com/dell/csi-powerscale/service/step_handlers_test.go

@rishabhatdell rishabhatdell merged commit 5028392 into main Jun 24, 2025
6 checks passed
@rishabhatdell rishabhatdell deleted the csi_sanity_fixes branch June 24, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants