Skip to content

Conversation

@JacobGros
Copy link
Contributor

@JacobGros JacobGros commented Aug 25, 2025

Description

#346 introduced a regression where 2 gocsi env vars were set to false:
image
This resulted in no CSI REQ/REP being logged by the driver. This PR brings back the REQ/REP logging that was missing.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/2000

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built image, verified REQ/REP was being logged again:
time="2025-08-25T17:05:47Z" level=info msg="/csi.v1.Node/NodeGetVolumeStats: REQ 0004: xxx
time="2025-08-25T17:05:47Z" level=info msg="/csi.v1.Node/NodeGetVolumeStats: REP 0004: xxx

@github-actions
Copy link
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/main.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@JacobGros JacobGros merged commit 437efc1 into main Aug 25, 2025
6 checks passed
@JacobGros JacobGros deleted the jacobgros/add-req-rep-logging branch August 25, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants